eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Avoid updating muted state on muted content attribute changes

Browse Source 
The `muted` content attribute should only affect the state of the
`muted` IDL property when the media element is first created. The
attribute should have no dynamic effect.
This commit is contained in:
Tim Ledbetter
2025-06-26 10:28:17 +01:00
committed by Shannon Booth
parent ed6f2f9b81
commit 8828e0d791
Notes: github-actions[bot] 2025-06-26 21:16:18 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8828e0d7919
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5223
Reviewed-by: https://github.com/shannonbooth ✅
4 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -107,8 +107,6 @@ void HTMLMediaElement::attribute_changed(FlyString const& name, Optional<String>
load_element().release_value_but_fixme_should_propagate_errors();
} else if (name == HTML::AttributeNames::crossorigin) {
m_crossorigin = cors_setting_attribute_from_keyword(value);
} else if (name == HTML::AttributeNames::muted) {
set_muted(true);
}
}