eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Replace ARIA role static FlyStrings with an enum

Browse Source 
This replaces the FlyStrings for ARIA roles that were constructed in
a [[gnu::constructor]] with a single enum. I came across this as the
DOM inspector was crashing due to a null FlyString for an ARIA role.

After fixing that, I was confused as to why these roles were not an
enum. Looking at the spec there's a fixed list of roles and switching
from references to static strings to an enum was pretty much an
exercise in find and replace :).

No functional changes (outside of fixing the mentioned crash).
This commit is contained in:
MacDue
2023-01-29 19:12:00 +01:00
committed by Linus Groh
parent f23eba1ba8
commit 890b4d7980
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00 
Author: https://github.com/MacDue
Commit: https://github.com/SerenityOS/serenity/commit/890b4d7980
Pull-request: https://github.com/SerenityOS/serenity/pull/17226
Reviewed-by: https://github.com/linusg ✅
59 changed files with 344 additions and 327 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLTableCellElement.cpp
View File

@@ -74,7 +74,7 @@ void HTMLTableCellElement::set_row_span(unsigned int value)
MUST(set_attribute(HTML::AttributeNames::rowspan, DeprecatedString::number(value)));
}
DeprecatedFlyString HTMLTableCellElement::default_role() const
Optional<DOM::ARIARoles::Role> HTMLTableCellElement::default_role() const
{
// TODO: For td:
// role=cell if the ancestor table element is exposed as a role=table