eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Separate raw and capturing native functions

Browse Source 
NativeFunction previously stored an AK::Function for every builtin,
even when the callable was just a plain C++ entry point. That mixed
together two different representations, made simple builtins carry
capture storage they did not need, and forced the GC to treat every
native function as if it might contain captured JS values.

Introduce RawNativeFunction for plain NativeFunctionPointer callees
and keep AK::Function-backed callables on a CapturingNativeFunction
subclass. Update the straightforward native registrations in LibJS
and LibWeb to use the raw representation, while leaving exported
Wasm functions on the capturing path because they still capture
state.

Wrap UniversalGlobalScope's byte-length strategy lambda in
Function<...> explicitly so it keeps selecting the capturing
NativeFunction::create overload.
This commit is contained in:
Andreas Kling
2026-04-14 21:45:44 +02:00
committed by Andreas Kling
parent fadea53343
commit 8a9d5ee1a1
Notes: github-actions[bot] 2026-04-15 13:59:08 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8a9d5ee1a12
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8922
Reviewed-by: https://github.com/shannonbooth
9 changed files with 163 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Libraries/LibJS/Runtime/NativeFunction.h
View File

@@ -22,7 +22,9 @@ class JS_API NativeFunction : public FunctionObject {
public:
static GC::Ref<NativeFunction> create(Realm&, ESCAPING Function<ThrowCompletionOr<Value>(VM&)> behaviour, i32 length, PropertyKey const& name = Utf16FlyString {}, Optional<Realm*> = {}, Optional<StringView> const& prefix = {}, Optional<Bytecode::Builtin> builtin = {});
static GC::Ref<NativeFunction> create(Realm&, NativeFunctionPointer behaviour, i32 length, PropertyKey const& name = Utf16FlyString {}, Optional<Realm*> = {}, Optional<StringView> const& prefix = {}, Optional<Bytecode::Builtin> builtin = {});
static GC::Ref<NativeFunction> create(Realm&, Utf16FlyString const& name, ESCAPING Function<ThrowCompletionOr<Value>(VM&)>);
static GC::Ref<NativeFunction> create(Realm&, Utf16FlyString const& name, NativeFunctionPointer);
virtual ~NativeFunction() override = default;
@@ -30,7 +32,6 @@ public:
virtual ThrowCompletionOr<GC::Ref<Object>> internal_construct(ExecutionContext&, FunctionObject& new_target) override;
// Used for [[Call]] / [[Construct]]'s "...result of evaluating F in a manner that conforms to the specification of F".
// Needs to be overridden by all NativeFunctions without an m_native_function.
virtual ThrowCompletionOr<Value> call();
virtual ThrowCompletionOr<GC::Ref<Object>> construct(FunctionObject& new_target);
@@ -48,9 +49,8 @@ public:
virtual size_t function_environment_bindings_count() const { return 0; }
protected:
NativeFunction(Object* prototype, Realm& realm, Optional<Bytecode::Builtin> builtin);
NativeFunction(Utf16FlyString name, Object& prototype);
NativeFunction(AK::Function<ThrowCompletionOr<Value>(VM&)>, Object* prototype, Realm& realm, Optional<Bytecode::Builtin> builtin);
NativeFunction(Utf16FlyString name, AK::Function<ThrowCompletionOr<Value>(VM&)>, Object& prototype);
explicit NativeFunction(Object& prototype);
virtual void visit_edges(Cell::Visitor& visitor) override;
@@ -60,11 +60,36 @@ private:
Utf16FlyString m_name;
Optional<Utf16FlyString> m_initial_name; // [[InitialName]]
AK::Function<ThrowCompletionOr<Value>(VM&)> m_native_function;
GC::Ref<Realm> m_realm;
};
template<>
inline bool Object::fast_is<NativeFunction>() const { return is_native_function(); }
class JS_API RawNativeFunction final : public NativeFunction {
JS_OBJECT(RawNativeFunction, NativeFunction);
GC_DECLARE_ALLOCATOR(RawNativeFunction);
public:
static GC::Ref<RawNativeFunction> create(Realm&, NativeFunctionPointer behaviour, i32 length, PropertyKey const& name = Utf16FlyString {}, Optional<Realm*> = {}, Optional<StringView> const& prefix = {}, Optional<Bytecode::Builtin> builtin = {});
static GC::Ref<RawNativeFunction> create(Realm&, Utf16FlyString const& name, NativeFunctionPointer);
virtual ~RawNativeFunction() override = default;
virtual ThrowCompletionOr<Value> call() override;
NativeFunctionPointer native_function() const { return m_native_function; }
private:
RawNativeFunction(NativeFunctionPointer, Object* prototype, Realm& realm, Optional<Bytecode::Builtin> builtin);
RawNativeFunction(Utf16FlyString name, NativeFunctionPointer, Object& prototype);
virtual bool is_raw_native_function() const final { return true; }
NativeFunctionPointer m_native_function { nullptr };
};
template<>
inline bool Object::fast_is<RawNativeFunction>() const { return is_raw_native_function(); }
}