eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/WebGL: Respect UNPACK_PREMULTIPLY_ALPHA

Browse Source 
Fixes splats on https://superspl.at having dark splotches, as they
expect textures with unpremultiplied alpha.
This commit is contained in:
Luke Wilde
2025-11-04 14:31:24 +00:00
committed by Jelle Raaijmakers
parent 8f666c6360
commit 8adde0980a
Notes: github-actions[bot] 2025-11-04 16:07:39 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8adde0980a6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6694
Reviewed-by: https://github.com/gmta ✅
4 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/WebGL/WebGLRenderingContextBase.cpp
View File

@@ -166,11 +166,10 @@ Optional<WebGLRenderingContextBase::ConvertedTexture> WebGLRenderingContextBase:
auto buffer = MUST(ByteBuffer::create_zeroed(buffer_pitch.value() * height));
if (width > 0 && height > 0) {
// FIXME: Respect UNPACK_PREMULTIPLY_ALPHA_WEBGL
// FIXME: Respect unpackColorSpace
auto skia_format = opengl_format_and_type_to_skia_color_type(format, type);
auto color_space = SkColorSpace::MakeSRGB();
auto image_info = SkImageInfo::Make(width, height, skia_format, SkAlphaType::kPremul_SkAlphaType, color_space);
auto image_info = SkImageInfo::Make(width, height, skia_format, m_unpack_premultiply_alpha ? SkAlphaType::kPremul_SkAlphaType : SkAlphaType::kUnpremul_SkAlphaType, color_space);
auto surface = SkSurfaces::WrapPixels(image_info, buffer.data(), buffer_pitch.value());
VERIFY(surface);
auto surface_canvas = surface->getCanvas();