eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Consider semicolon in parse_descriptor_value a SyntaxError

Browse Source 
Everywhere we use this expects us to parse the whole value, either
because we are parsing the value of a declaration (in which case there
will be no semicolons), or because it is called from a JS setter which
takes whole values and semicolons make the value invalid.

Previously we would just ignore everything after a semicolon.

This also allows us to avoid creating a new `Vector` and copying all the
component values
This commit is contained in:
Callum Law
2026-03-28 20:26:23 +13:00
committed by Sam Atkins
parent 7d2f772317
commit 8b66e7f463
Notes: github-actions[bot] 2026-03-30 18:59:04 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8b66e7f4630
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8653
Reviewed-by: https://github.com/AtkinsSJ ✅
3 changed files with 25 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Tests/LibWeb/Text/input/css/descriptor-value-trailing-semicolon.html Normal file
View File

@@ -0,0 +1,13 @@
<!doctype html>
<script src="../include.js"></script>
<script>
test(() => {
const face = new FontFace("Foo", "url(foo.woff2)");
try {
face.weight = "400;";
println(`FAIL`);
} catch (error) {
println(`PASS`);
}
});
</script>