eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibUnicode: Change time zones in a way that works on Windows

Browse Source 
On Windows, ICU does not look at the TZ environment variable at all. So
to support changing time zones in test-js, let's set ICU's default time
zone directly.

Note that we no longer deal with "null" time zone strings. We just cache
whatever ICU thinks is the current time zone before attempting to change
it, for which we never have a null result.

Co-authored-by: Andrew Kaster <andrew@ladybird.org>
This commit is contained in:
Timothy Flynn
2025-06-01 08:22:19 -04:00
committed by Tim Flynn
parent 8d33a97630
commit 8ded0c65dc
Notes: github-actions[bot] 2025-06-01 22:50:05 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/8ded0c65dcd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4955
Reviewed-by: https://github.com/ADKaster ✅
4 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibUnicode/TimeZone.h
View File

@@ -1,11 +1,12 @@
/*
* Copyright (c) 2024, Tim Flynn <trflynn89@serenityos.org>
* Copyright (c) 2024-2025, Tim Flynn <trflynn89@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/Error.h>
#include <AK/Optional.h>
#include <AK/String.h>
#include <AK/Time.h>
@@ -24,6 +25,7 @@ struct TimeZoneOffset {
};
String current_time_zone();
ErrorOr<void> set_current_time_zone(StringView);
void clear_system_time_zone_cache();
Vector<String> const& available_time_zones();
Vector<String> available_time_zones_in_region(StringView region);