eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGfx/TGA: Move a variable closer to its use

Browse Source 
No behavior change.
This commit is contained in:
Nico Weber
2024-03-07 20:35:53 -05:00
committed by Andreas Kling
parent 6607757b08
commit 8ec6dad449
Notes: sideshowbarker 2024-07-18 00:54:03 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/8ec6dad449
Pull-request: https://github.com/SerenityOS/serenity/pull/23518
Reviewed-by: https://github.com/LucasChollet ✅
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibGfx/ImageFormats/TGALoader.cpp
View File

@@ -76,9 +76,9 @@ IntSize TGAImageDecoderPlugin::size()
static ErrorOr<void> ensure_header_validity(TGAHeader const& header, size_t whole_image_stream_size)
{
auto bytes_remaining = whole_image_stream_size - sizeof(TGAHeader);
if ((header.bits_per_pixel % 8) != 0 || header.bits_per_pixel < 8 || header.bits_per_pixel > 32)
return Error::from_string_literal("Invalid bit depth");
auto bytes_remaining = whole_image_stream_size - sizeof(TGAHeader);
if (header.data_type_code == TGADataType::UncompressedRGB && bytes_remaining < static_cast<u64>(header.width) * header.height * (header.bits_per_pixel / 8))
return Error::from_string_literal("Not enough data to read an image with the expected size");
return {};