eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't synchronously set media element's seeking attribute false

Browse Source 
This could cause the attribute to be false when the seeking event
fired.
This commit is contained in:
Zaggy1024
2026-02-26 15:22:49 -06:00
committed by Gregory Bertilson
parent d6530d070f
commit 93537276e6
Notes: github-actions[bot] 2026-02-27 04:04:13 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/93537276e62
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8179
Reviewed-by: https://github.com/shannonbooth
Reviewed-by: https://github.com/trflynn89
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -1990,9 +1990,15 @@ void HTMLMediaElement::seek_element(double playback_position, MediaSeekMode seek
// 13. Await a stable state. The synchronous section consists of all the remaining steps of this algorithm. (Steps in the
// synchronous section are marked with ⌛.)
if (m_playback_manager) {
// NOTE: The final steps are triggered by our playback manager exiting the seeking state its playing/paused state.
// NB: The final steps are triggered by our playback manager exiting the seeking state its playing/paused state.
} else {
finish_seeking_element();
// NB: Queue a media element task to ensure that that the seeking attribute is true while the seeking event fires.
// Awaiting a stable state seems to require a task to be queued anyway, and we use media element tasks to cancel
// ongoing operations when load_element() is called.
// See: https://github.com/whatwg/html/issues/2882#issuecomment-1108531815
queue_a_media_element_task([this]() {
finish_seeking_element();
});
}
}