eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make Environment's top level origin nullable

Browse Source 
This matches the definition in the spec, and is also a step towards
removing the default constructor of URL::Origin.
This commit is contained in:
Shannon Booth
2025-05-25 16:47:37 +12:00
committed by Shannon Booth
parent 556acd82ee
commit 937994cfaa
Notes: github-actions[bot] 2025-05-27 02:49:41 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/937994cfaa8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4878
Reviewed-by: https://github.com/trflynn89
11 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -428,7 +428,7 @@ Navigable::ChosenNavigable Navigable::choose_a_navigable(StringView name, Tokeni
// 4. If currentDocument's opener policy's value is "same-origin" or "same-origin-plus-COEP",
// and currentDocument's origin is not same origin with currentDocument's relevant settings object's top-level origin, then:
if ((current_document->opener_policy().value == OpenerPolicyValue::SameOrigin || current_document->opener_policy().value == OpenerPolicyValue::SameOriginPlusCOEP)
&& !current_document->origin().is_same_origin(relevant_settings_object(*current_document).top_level_origin)) {
&& !current_document->origin().is_same_origin(relevant_settings_object(*current_document).top_level_origin.value())) {
// 1. Set noopener to true.
no_opener = TokenizedFeature::NoOpener::Yes;
@@ -936,7 +936,7 @@ static WebIDL::ExceptionOr<Navigable::NavigationParamsVariant> create_navigation
Optional<URL::URL> top_level_creation_url = current_url;
// 2. Let topLevelOrigin be null.
URL::Origin top_level_origin;
Optional<URL::Origin> top_level_origin;
// 3. If navigable is not a top-level traversable, then:
if (!navigable->is_top_level_traversable()) {