eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Avoid dereferencing an empty optional URL

Browse Source 
Here, "null" means the empty optional. We don't need to also check if
the URL is valid; the url will be null if it was originally invalid.
This commit is contained in:
Timothy Flynn
2024-12-11 12:04:02 -05:00
committed by Tim Flynn
parent 0bc55424c8
commit 943ec820fc
Notes: github-actions[bot] 2024-12-11 17:34:46 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/943ec820fc5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2880
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View File

@@ -427,7 +427,7 @@ String HTMLHyperlinkElementUtils::href() const
return String {};
// 4. Otherwise, if url is null, return this element's href content attribute's value.
if (!url->is_valid())
if (!url.has_value())
return href_content_attribute.release_value();
// 5. Return url, serialized.