eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove unnecessary value_or() from get()

Browse Source 
Object::get() never returns an empty value anymore, as per the spec, so
having a value_or() fallback is no longer needed.
This commit is contained in:
Linus Groh
2021-07-04 22:55:45 +01:00
committed by Andreas Kling
parent 57f7e6e775
commit 9555ca99a0
Notes: sideshowbarker 2024-07-18 10:25:40 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/9555ca99a03
Pull-request: https://github.com/SerenityOS/serenity/pull/8442
Reviewed-by: https://github.com/IdanHo ✅
19 changed files with 56 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Object.cpp
View File

@@ -1216,7 +1216,7 @@ Value Object::ordinary_to_primitive(Value::PreferredType preferred_type) const
Value Object::invoke_internal(const StringOrSymbol& property_name, Optional<MarkedValueList> arguments)
{
auto& vm = this->vm();
auto property = get(property_name).value_or(js_undefined());
auto property = get(property_name);
if (vm.exception())
return {};
if (!property.is_function()) {