eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Port some manually async tests to use asyncTest

Browse Source 
These tests were mostly async tests written in a manual way. This ports
them to use the standard asyncTest() infrastructure.

This is mostly just to reduce calls to internals.signalTextTestIsDone,
which will have a required parameter in an upcoming test.
This commit is contained in:
Timothy Flynn
2024-10-02 12:31:42 -04:00
committed by Tim Flynn
parent d5ba665f89
commit 96082d6ae1
Notes: github-actions[bot] 2024-10-03 11:08:43 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/96082d6ae12
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1603
Reviewed-by: https://github.com/awesomekling ✅
Reviewed-by: https://github.com/circl-lastname
Reviewed-by: https://github.com/kalenikaliaksandr ✅
5 changed files with 64 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Tests/LibWeb/Text/input/navigation/remove-iframe-from-timeout-callback.html
View File

@@ -2,11 +2,13 @@
<div id="foo">
<iframe></iframe>
<script>
setTimeout(function () {
foo.remove();
// Pass (didn't crash)
internals.signalTextTestIsDone();
}, 0);
asyncTest(done => {
setTimeout(function () {
foo.remove();
// Pass (didn't crash)
done();
}, 0);
});
</script>
</div>
<iframe></iframe>