eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Do not execute scripts with parse errors

Browse Source 
This adds missing checks in several LibJS consumers.
This commit is contained in:
Stephan Unverwerth
2020-04-13 02:05:21 +02:00
committed by Andreas Kling
parent 50b6b6ef86
commit 984c290ec0
Notes: sideshowbarker 2024-07-19 07:38:28 +09:00 
Author: https://github.com/sunverwerth
Commit: https://github.com/SerenityOS/serenity/commit/984c290ec04
Pull-request: https://github.com/SerenityOS/serenity/pull/1775
4 changed files with 36 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/LibWeb/DOM/HTMLScriptElement.cpp
View File

@@ -59,7 +59,11 @@ void HTMLScriptElement::children_changed()
if (source.is_empty())
return;
auto program = JS::Parser(JS::Lexer(source)).parse_program();
auto parser = JS::Parser(JS::Lexer(source));
auto program = parser.parse_program();
if (parser.has_errors())
return;
document().interpreter().run(*program);
}
@@ -90,7 +94,11 @@ void HTMLScriptElement::inserted_into(Node& new_parent)
return;
}
auto program = JS::Parser(JS::Lexer(source)).parse_program();
auto parser = JS::Parser(JS::Lexer(source));
auto program = parser.parse_program();
if (parser.has_errors())
return;
document().interpreter().run(*program);
}