eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse Source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth
2024-11-14 05:50:17 +13:00
committed by Tim Flynn
parent 2a5dbedad4
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9b79a686eb1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2322
Reviewed-by: https://github.com/gmta
326 changed files with 697 additions and 714 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/ResizeObserver/ResizeObservation.cpp
View File

@@ -16,7 +16,7 @@ JS_DEFINE_ALLOCATOR(ResizeObservation);
WebIDL::ExceptionOr<JS::NonnullGCPtr<ResizeObservation>> ResizeObservation::create(JS::Realm& realm, DOM::Element& target, Bindings::ResizeObserverBoxOptions observed_box)
{
return realm.heap().allocate<ResizeObservation>(realm, realm, target, observed_box);
return realm.create<ResizeObservation>(realm, target, observed_box);
}
ResizeObservation::ResizeObservation(JS::Realm& realm, DOM::Element& target, Bindings::ResizeObserverBoxOptions observed_box)
@@ -24,7 +24,7 @@ ResizeObservation::ResizeObservation(JS::Realm& realm, DOM::Element& target, Bin
, m_target(target)
, m_observed_box(observed_box)
{
auto computed_size = realm.heap().allocate<ResizeObserverSize>(realm, realm);
auto computed_size = realm.create<ResizeObserverSize>(realm);
m_last_reported_sizes.append(computed_size);
}