eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Avoid resetting important flag when recomputing inherited style

Browse Source 
We were missing the important flag here so would always reset it to
false
This commit is contained in:
Callum Law
2025-11-15 00:48:15 +13:00
committed by Sam Atkins
parent 9d2ecc069f
commit 9de4e3a0eb
Notes: github-actions[bot] 2025-11-28 16:17:27 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9de4e3a0eb9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6837
Reviewed-by: https://github.com/AtkinsSJ ✅
3 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
Tests/LibWeb/Ref/input/css/recomputing-inherited-style-doesnt-remove-important.html Normal file
View File

@@ -0,0 +1,28 @@
<!DOCTYPE html>
<link rel="match" href="../../expected/css/recomputing-inherited-style-doesnt-remove-important-ref.html" />
<style>
@keyframes fontSize {
from {
width: 5em;
}
to {
width: 5em;
}
}
#bar {
width: 1em !important;
animation: fontSize 1s infinite;
background-color: green;
height: 1em;
}
</style>
<div id="foo"><div id="bar"></div></div>
<script>
requestAnimationFrame(() => {
requestAnimationFrame(() => {
getComputedStyle(foo).fontSize;
foo.style.setProperty("color", "blue");
});
});
</script>