eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Services/WebDriver: Enable on Windows

Browse Source
This commit is contained in:
ayeteadoe
2025-08-23 21:03:37 -07:00
committed by Jelle Raaijmakers
parent 69e92f69a7
commit 9f23b0a069
Notes: github-actions[bot] 2025-09-15 07:43:43 +00:00 
Author: https://github.com/ayeteadoe
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9f23b0a0693
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5972
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/gmta ✅
3 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Services/CMakeLists.txt
View File

@@ -1,11 +1,5 @@
add_subdirectory(ImageDecoder)
add_subdirectory(RequestServer)
add_subdirectory(WebContent)
add_subdirectory(WebWorker)
# FIXME: Increase support for building targets on Windows
if (WIN32 AND ENABLE_WINDOWS_CI)
return()
endif()
add_subdirectory(WebDriver)
add_subdirectory(WebWorker)

7
Services/WebDriver/Session.cpp
View File

@@ -18,7 +18,6 @@
#include <LibWeb/WebDriver/TimeoutsConfiguration.h>
#include <LibWeb/WebDriver/UserPrompt.h>
#include <WebDriver/Session.h>
#include <unistd.h>
namespace WebDriver {
@@ -195,7 +194,11 @@ void Session::close()
ErrorOr<NonnullRefPtr<Core::LocalServer>> Session::create_server(NonnullRefPtr<ServerPromise> promise)
{
#if defined(AK_OS_WINDOWS)
static_assert(IsSame<IPC::Transport, IPC::TransportSocketWindows>, "Need to handle other IPC transports here");
#else
static_assert(IsSame<IPC::Transport, IPC::TransportSocket>, "Need to handle other IPC transports here");
#endif
dbgln("Listening for WebDriver connection on {}", *m_web_content_socket_path);
@@ -254,7 +257,7 @@ ErrorOr<void> Session::start(LaunchBrowserCallback const& launch_browser_callbac
{
auto promise = ServerPromise::construct();
m_web_content_socket_path = ByteString::formatted("{}/webdriver/session_{}_{}", TRY(Core::StandardPaths::runtime_directory()), getpid(), m_session_id);
m_web_content_socket_path = ByteString::formatted("{}/webdriver/session_{}_{}", TRY(Core::StandardPaths::runtime_directory()), Core::System::getpid(), m_session_id);
m_web_content_server = TRY(create_server(promise));
m_browser_process = TRY(launch_browser_callback(*m_web_content_socket_path, m_options.headless));

1
Services/WebDriver/Session.h
View File

@@ -22,7 +22,6 @@
#include <LibWeb/WebDriver/Response.h>
#include <WebDriver/Client.h>
#include <WebDriver/WebContentConnection.h>
#include <unistd.h>
namespace WebDriver {