eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Handle non-OK network responses in <object> elements

Browse Source 
We were previously only testing for network errors, which includes e.g.
DNS resolution and connection errors. It does not include e.g. HTTP 404
responses, which is exercised by Acid 2.
This commit is contained in:
Timothy Flynn
2025-05-21 12:26:31 -04:00
committed by Andrew Kaster
parent fc204c8732
commit 9f3526b080
Notes: github-actions[bot] 2025-05-21 18:14:26 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/9f3526b0803
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4834
Reviewed-by: https://github.com/ADKaster ✅
3 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View File

@@ -297,7 +297,7 @@ void HTMLObjectElement::queue_element_task_to_run_object_representation_steps()
auto& realm = this->realm();
auto& global = document().realm().global_object();
if (response->is_network_error()) {
if (response->is_network_error() || !Fetch::Infrastructure::is_ok_status(response->status())) {
resource_did_fail();
return;
}