eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 13:02:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Replace GlobalObject with VM in Value AOs [Part 4/19]

Browse Source 
This is where the fun begins. :^)
This commit is contained in:
Linus Groh
2022-08-21 14:00:56 +01:00
parent f6c4a0f5d0
commit a022e548b8
Notes: sideshowbarker 2024-07-17 08:00:44 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/a022e548b8
Pull-request: https://github.com/SerenityOS/serenity/pull/14973
Reviewed-by: https://github.com/davidot ✅
129 changed files with 1230 additions and 1325 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/DataViewConstructor.cpp
View File

@@ -48,7 +48,7 @@ ThrowCompletionOr<Object*> DataViewConstructor::construct(FunctionObject& new_ta
auto& array_buffer = static_cast<ArrayBuffer&>(buffer.as_object());
auto offset = TRY(vm.argument(1).to_index(global_object));
auto offset = TRY(vm.argument(1).to_index(vm));
if (array_buffer.is_detached())
return vm.throw_completion<TypeError>(ErrorType::DetachedArrayBuffer);
@@ -61,7 +61,7 @@ ThrowCompletionOr<Object*> DataViewConstructor::construct(FunctionObject& new_ta
if (vm.argument(2).is_undefined()) {
view_byte_length = buffer_byte_length - offset;
} else {
view_byte_length = TRY(vm.argument(2).to_index(global_object));
view_byte_length = TRY(vm.argument(2).to_index(vm));
auto const checked_add = AK::make_checked(view_byte_length) + AK::make_checked(offset);
if (checked_add.has_overflow() || checked_add.value() > buffer_byte_length)
return vm.throw_completion<RangeError>(ErrorType::InvalidLength, vm.names.DataView);