eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 02:27:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Replace GlobalObject with VM in Value AOs [Part 4/19]

Browse Source 
This is where the fun begins. :^)
This commit is contained in:
Linus Groh
2022-08-21 14:00:56 +01:00
parent f6c4a0f5d0
commit a022e548b8
Notes: sideshowbarker 2024-07-17 08:00:44 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/a022e548b8
Pull-request: https://github.com/SerenityOS/serenity/pull/14973
Reviewed-by: https://github.com/davidot ✅
129 changed files with 1230 additions and 1325 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp
View File

@@ -51,7 +51,6 @@ double compare_strings(Collator& collator, Utf8View const& x, Utf8View const& y)
ThrowCompletionOr<Value> CollatorCompareFunction::call()
{
auto& vm = this->vm();
auto& global_object = this->global_object();
// 1. Let collator be F.[[Collator]].
// 2. Assert: Type(collator) is Object and collator has an [[InitializedCollator]] internal slot.
@@ -59,9 +58,9 @@ ThrowCompletionOr<Value> CollatorCompareFunction::call()
// 4. If y is not provided, let y be undefined.
// 5. Let X be ? ToString(x).
auto x = TRY(vm.argument(0).to_string(global_object));
auto x = TRY(vm.argument(0).to_string(vm));
// 6. Let Y be ? ToString(y).
auto y = TRY(vm.argument(1).to_string(global_object));
auto y = TRY(vm.argument(1).to_string(vm));
// 7. Return CompareStrings(collator, X, Y).
return compare_strings(m_collator, Utf8View(x), Utf8View(y));