eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add & when setting nested style rule's selector text

Browse Source 
When we first parse a nested CSSStyleRule's selectors, we treat them as
relative selectors and then patch them up with an `&` as needed.
However, we weren't doing this when assigning the `cssText` attribute.
So, let's do that!

This gives us a couple of subtest passes. :^)
This commit is contained in:
Sam Atkins
2024-11-08 17:50:38 +00:00
committed by Andreas Kling
parent 3e0c182344
commit a0403ac427
Notes: github-actions[bot] 2024-11-09 13:30:38 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a0403ac4277
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2240
9 changed files with 77 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/wpt-import/css/css-nesting/nested-declarations-matching.txt
View File

@@ -6,7 +6,8 @@ Rerun
Found 11 tests
11 Fail
1 Pass
10 Fail
Details
Result Test Name MessageFail Trailing declarations apply after any preceding rules
Fail Trailing declarations apply after any preceding rules (no leading)
@@ -18,4 +19,4 @@ Fail Bare declartaion in nested grouping rule can match pseudo-element
Fail Nested group rules have top-level specificity behavior
Fail Nested @scope rules behave like :where(:scope)
Fail Nested @scope rules behave like :where(:scope) (trailing)
Fail Nested declarations rule responds to parent selector text change
Pass Nested declarations rule responds to parent selector text change