eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move use pseudo element styles from TreeBuilder to StyleComputer

Browse Source 
The styling of elements using the `use_pseudo_element()` was only
applied on layout. When an element style was recomputed later that
styling was not overruled with the pseudo element selector styles.
This moves the styling override from `TreeBuilder.cpp` to
`StyleComputer.cpp`. Now the styles are always correctly applied.
I also removed the method `property_id_by_index()` because it was
not needed anymore.

Als some calls to `invalidate_layout()` in the Meter, Progress and
Select elements where not needed anymore because the style values
are update on the changing of the style attribute.

This fixes issue #22278.
This commit is contained in:
Bastiaan van der Plaat
2023-12-17 21:03:28 +01:00
committed by Andreas Kling
parent 7578620f25
commit a05fd28b7b
Notes: sideshowbarker 2024-07-17 05:05:51 +09:00 
Author: https://github.com/bplaat
Commit: https://github.com/SerenityOS/serenity/commit/a05fd28b7b
Pull-request: https://github.com/SerenityOS/serenity/pull/22307
11 changed files with 44 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.h
View File

@@ -21,7 +21,6 @@ public:
virtual size_t length() const override;
virtual String item(size_t index) const override;
virtual CSS::PropertyID property_id_by_index(size_t index) const override;
virtual Optional<StyleProperty> property(PropertyID) const override;
virtual WebIDL::ExceptionOr<void> set_property(PropertyID, StringView css_text, StringView priority) override;