eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use unsafe layout/paintable accessors where appropriate

Browse Source 
Add unsafe_layout_node(), unsafe_paintable(), and unsafe_paintable_box()
accessors that skip layout-staleness verification. These are for use in
contexts where accessing layout/paintable data is legitimate despite
layout not being up to date: tree construction, style recalculation,
painting, animation interpolation, DOM mutation, and invalidation
propagation.

Also add wrapper APIs on Node to centralize common patterns:
- set_needs_display() wraps if (unsafe_paintable()) ...set_needs_display
- set_needs_paint_only_properties_update() wraps similar
- set_needs_layout_update() wraps if (unsafe_layout_node()) ...

And add Document::layout_is_up_to_date() which checks whether layout
tree update flags are all clear.
This commit is contained in:
Andreas Kling
2026-02-26 11:57:29 +01:00
committed by Andreas Kling
parent b8b63ddc8f
commit a146225331
Notes: github-actions[bot] 2026-02-26 20:10:33 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a146225331e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8182
48 changed files with 396 additions and 225 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -390,8 +390,7 @@ void HTMLMediaElement::set_duration(double duration)
upon_has_ended_playback_possibly_changed();
if (auto* paintable = this->paintable())
paintable->set_needs_display();
set_needs_display();
}
GC::Ref<WebIDL::Promise> HTMLMediaElement::play()
@@ -1287,8 +1286,7 @@ void HTMLMediaElement::update_video_frame_and_timeline()
auto sink_update_result = m_selected_video_track_sink->update();
if (sink_update_result == Media::DisplayingVideoSinkUpdateResult::NewFrameAvailable) {
ensure_external_content_source().update(m_selected_video_track_sink->current_frame());
if (paintable())
paintable()->set_needs_display();
set_needs_display();
}
}
@@ -1401,9 +1399,7 @@ void HTMLMediaElement::on_video_track_added(Media::Track const& track)
auto event = TrackEvent::create(realm, HTML::EventNames::addtrack, move(event_init));
m_video_tracks->dispatch_event(event);
// Update the VideoPaintable, so that it can potentially change representations based on the new video track count.
if (paintable())
paintable()->set_needs_display();
set_needs_display();
}
void HTMLMediaElement::on_metadata_parsed()
@@ -2001,8 +1997,7 @@ void HTMLMediaElement::set_show_poster(bool show_poster)
m_show_poster = show_poster;
if (auto* paintable = this->paintable())
paintable->set_needs_display();
set_needs_display();
}
void HTMLMediaElement::set_paused(bool paused)
@@ -2020,8 +2015,7 @@ void HTMLMediaElement::set_paused(bool paused)
document().page().client().page_did_change_audio_play_state(AudioPlayState::Paused);
}
if (auto* paintable = this->paintable())
paintable->set_needs_display();
set_needs_display();
set_needs_style_update(true);
}