eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Only fire resize at Window if the viewport size changed

Browse Source 
...and similarly, only fire resize at VisualViewport if its state has
changed.

Before, we would fire both if either changed.
This commit is contained in:
Zaggy1024
2026-03-16 04:55:47 -05:00
committed by Gregory Bertilson
parent 7a45b50e8d
commit a1c9fbacc6
Notes: github-actions[bot] 2026-03-18 00:00:46 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a1c9fbacc61
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8461
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Libraries/LibWeb/DOM/Document.cpp
View File

@@ -3691,7 +3691,7 @@ void Document::update_the_visibility_state(HTML::VisibilityState visibility_stat
dispatch_event(event);
}
// https://drafts.csswg.org/cssom-view/#run-the-resize-steps
// https://drafts.csswg.org/cssom-view/#document-run-the-resize-steps
void Document::run_the_resize_steps()
{
// 1. If doc’s viewport has had its width or height changed
@@ -3706,19 +3706,27 @@ void Document::run_the_resize_steps()
VisualViewportState visual_viewport_state = { visual_viewport.scale(), { visual_viewport.width(), visual_viewport.height() } };
bool is_initial_size = !m_last_viewport_size.has_value();
if (m_last_viewport_size == viewport_size && m_last_visual_viewport_state == visual_viewport_state)
bool viewport_size_changed = m_last_viewport_size != viewport_size;
bool visual_viewport_state_changed = m_last_visual_viewport_state != visual_viewport_state;
if (!viewport_size_changed && !visual_viewport_state_changed)
return;
m_last_viewport_size = viewport_size;
m_last_visual_viewport_state = visual_viewport_state;
if (!is_initial_size) {
auto window_resize_event = DOM::Event::create(realm(), UIEvents::EventNames::resize);
window_resize_event->set_is_trusted(true);
window()->dispatch_event(window_resize_event);
if (viewport_size_changed) {
auto window_resize_event = DOM::Event::create(realm(), UIEvents::EventNames::resize);
window_resize_event->set_is_trusted(true);
window()->dispatch_event(window_resize_event);
}
auto visual_viewport_resize_event = DOM::Event::create(realm(), UIEvents::EventNames::resize);
visual_viewport_resize_event->set_is_trusted(true);
visual_viewport.dispatch_event(visual_viewport_resize_event);
if (visual_viewport_state_changed) {
auto visual_viewport_resize_event = DOM::Event::create(realm(), UIEvents::EventNames::resize);
visual_viewport_resize_event->set_is_trusted(true);
visual_viewport.dispatch_event(visual_viewport_resize_event);
}
}
}