eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Everywhere: Fix trivial -Wunnecessary-virtual-specifier instances

Browse Source 
- `Threading::Thread` is not polymorphic, there is no need for a virtual
  destructor.
- `HTMLAnchorElement::has_download_preference` isn't overridden by
  anything.

This warning was introduced in llvm/llvm-project#131188.
This commit is contained in:
Daniel Bertalan
2025-05-12 15:31:17 +02:00
committed by Andrew Kaster
parent 456d750539
commit a2167f126d
Notes: github-actions[bot] 2025-05-12 17:41:45 +00:00 
Author: https://github.com/BertalanD
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a2167f126d6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4703
Reviewed-by: https://github.com/ADKaster ✅
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/HTML/HTMLAnchorElement.h
View File

@@ -38,12 +38,14 @@ public:
private:
HTMLAnchorElement(DOM::Document&, DOM::QualifiedName);
bool has_download_preference() const;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// ^DOM::EventTarget
virtual bool has_activation_behavior() const override;
virtual void activation_behavior(Web::DOM::Event const&) override;
virtual bool has_download_preference() const;
// ^DOM::Element
virtual void attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override;