eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 02:27:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Pass StringBuilder around during StyleValue serialization

Browse Source 
Previously, some StyleValues created a large number of intermediate
strings during serialization. Passing a StringBUilder into the
serialization function allows us to avoid a large number of these
unnecessary allocations.
This commit is contained in:
Tim Ledbetter
2026-01-08 12:02:18 +00:00
committed by Jelle Raaijmakers
parent 4b556feecf
commit a27d269721
Notes: github-actions[bot] 2026-01-09 09:02:40 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a27d269721e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7381
Reviewed-by: https://github.com/gmta ✅
136 changed files with 663 additions and 557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleValues/BasicShapeStyleValue.cpp
View File

@@ -264,11 +264,11 @@ Gfx::Path BasicShapeStyleValue::to_path(CSSPixelRect reference_box, Layout::Node
});
}
String BasicShapeStyleValue::to_string(SerializationMode mode) const
void BasicShapeStyleValue::serialize(StringBuilder& builder, SerializationMode mode) const
{
return m_basic_shape.visit([mode](auto const& shape) {
builder.append(m_basic_shape.visit([mode](auto const& shape) {
return shape.to_string(mode);
});
}));
}
// https://www.w3.org/TR/css-shapes-1/#basic-shape-computed-values