eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Pass StringBuilder around during StyleValue serialization

Browse Source 
Previously, some StyleValues created a large number of intermediate
strings during serialization. Passing a StringBUilder into the
serialization function allows us to avoid a large number of these
unnecessary allocations.
This commit is contained in:
Tim Ledbetter
2026-01-08 12:02:18 +00:00
committed by Jelle Raaijmakers
parent 4b556feecf
commit a27d269721
Notes: github-actions[bot] 2026-01-09 09:02:40 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a27d269721e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7381
Reviewed-by: https://github.com/gmta ✅
136 changed files with 663 additions and 557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleValues/ViewFunctionStyleValue.cpp
View File

@@ -8,9 +8,8 @@
namespace Web::CSS {
String ViewFunctionStyleValue::to_string(SerializationMode mode) const
void ViewFunctionStyleValue::serialize(StringBuilder& builder, SerializationMode mode) const
{
StringBuilder builder;
builder.append("view("sv);
if (m_axis != Axis::Block)
@@ -22,11 +21,10 @@ String ViewFunctionStyleValue::to_string(SerializationMode mode) const
if (m_axis != Axis::Block)
builder.append(' ');
builder.append(stringified_inset);
m_inset->serialize(builder, mode);
}
builder.append(')');
return builder.to_string_without_validation();
}
ValueComparingNonnullRefPtr<StyleValue const> ViewFunctionStyleValue::absolutized(ComputationContext const& computation_context) const