eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Help: Remove redundant selection update when opening page

Browse Source 
Since the selection already gets updated in AbstractView::keydown_event
and AbstractView::mousedown_event we don't have to update it again in
the MainWidget::open_url function.

This fixes a bug that causes the selection to "spaz out" when
scrolling too fast between pages.
This commit is contained in:
kimlintu
2022-03-06 11:44:33 +01:00
committed by Linus Groh
parent 97c0a8c063
commit a4e3ae0ee9
Notes: sideshowbarker 2024-07-17 17:41:58 +09:00 
Author: https://github.com/kimlintu
Commit: https://github.com/SerenityOS/serenity/commit/a4e3ae0ee9
Pull-request: https://github.com/SerenityOS/serenity/pull/12905
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Applications/Help/MainWidget.cpp
View File

@@ -292,7 +292,6 @@ void MainWidget::open_url(URL const& url)
auto browse_view_index = m_manual_model->index_from_path(path);
if (browse_view_index.has_value()) {
m_browse_view->expand_tree(browse_view_index.value().parent());
m_browse_view->selection().set(browse_view_index.value());
String page_and_section = m_manual_model->page_and_section(browse_view_index.value());
window()->set_title(String::formatted("{} - Help", page_and_section));