eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Reuse IDBObjectStore instances in IDBTransaction.objectStore

Browse Source 
The spec mandates that the same object store have the same handle on
a transaction.
This commit is contained in:
Zaggy1024
2026-03-05 18:08:43 -06:00
committed by Gregory Bertilson
parent 1b4d93e7a6
commit a7897a7f9d
Notes: github-actions[bot] 2026-03-21 05:01:21 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a7897a7f9d2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8295
7 changed files with 136 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibWeb/IndexedDB/IDBDatabase.cpp
View File

@@ -147,7 +147,8 @@ WebIDL::ExceptionOr<GC::Ref<IDBObjectStore>> IDBDatabase::create_object_store(St
add_to_object_store_set(object_store);
// 10. Return a new object store handle associated with store and transaction.
return IDBObjectStore::create(realm, object_store, *transaction);
transaction->add_to_scope(object_store);
return transaction->get_or_create_object_store_handle(object_store);
}
// https://w3c.github.io/IndexedDB/#dom-idbdatabase-objectstorenames
@@ -187,7 +188,13 @@ WebIDL::ExceptionOr<void> IDBDatabase::delete_object_store(String const& name)
// 5. Remove store from this's object store set.
this->remove_from_object_store_set(*store);
// FIXME: 6. If there is an object store handle associated with store and transaction, remove all entries from its index set.
// NB: Upgrade transactions' scope is always the entire database. Since we removed this store from the database,
// it no longer belongs in the scope.
transaction->remove_from_scope(*store);
// 6. If there is an object store handle associated with store and transaction, remove all entries from its index set.
if (auto handle = transaction->object_store_handle_for(*store))
handle->index_set().clear();
// AD-HOC: Mark the store and its indexes as deleted so that stale handles throw InvalidStateError.
store->set_deleted(true);