eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 20:17:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove redundant invocation of children changed in HTMLParser

Browse Source 
Setting the `data` of a text node already triggers `children changed`
per spec, so there's no need for an explicit call.

This avoids parsing every HTMLStyleElement sheet twice. :^)
This commit is contained in:
Andreas Kling
2023-03-30 09:02:28 +02:00
parent 7319deb03d
commit a925c2dcf2
Notes: sideshowbarker 2024-07-17 07:25:39 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/a925c2dcf2
Pull-request: https://github.com/SerenityOS/serenity/pull/18098
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View File

@@ -957,7 +957,6 @@ void HTMLParser::flush_character_insertions()
if (m_character_insertion_builder.is_empty())
return;
m_character_insertion_node->set_data(m_character_insertion_builder.to_deprecated_string());
m_character_insertion_node->parent()->children_changed();
m_character_insertion_builder.clear();
}