eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb: Add missing GC marking visits

Browse Source 
This adds visit_edges(Cell::Visitor&) methods to various helper structs
that contain GC pointers, and makes sure they are called from owning
GC-heap-allocated objects as needed.

These were found by our Clang plugin after expanding its capabilities.
The added rules will be enforced by CI going forward.
This commit is contained in:
Andreas Kling
2026-01-06 00:36:34 +01:00
committed by Andreas Kling
parent 2677338f43
commit a9cc425cde
Notes: github-actions[bot] 2026-01-07 11:50:00 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a9cc425cdee
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7351
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/trflynn89
41 changed files with 322 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/LibWeb/HTML/HTMLFormElement.cpp
View File

@@ -67,6 +67,7 @@ void HTMLFormElement::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_associated_elements);
visitor.visit(m_planned_navigation);
visitor.visit(m_rel_list);
visitor.visit(m_past_names_map);
}
// https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#implicit-submission