eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Dont compute style when CSSStyleProperties lacks owner node

Browse Source 
Some instances of CSSStyleProperties can lack an owner node, for
instance the return value of a call to `window.getComputedStyle` where
the specified pseudo-element is invalid. In this case we should treat
the computed style as empty, as there is no node to compute the style
for.
This commit is contained in:
Callum Law
2025-06-09 14:11:22 +12:00
committed by Tim Ledbetter
parent fc46abb83f
commit a9eecf76df
Notes: github-actions[bot] 2025-06-09 11:29:45 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/a9eecf76df3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5034
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/tcl3 ✅
3 changed files with 342 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Tests/LibWeb/Text/expected/wpt-import/css/cssom/getComputedStyle-pseudo.txt Normal file
View File

@@ -0,0 +1,33 @@
Harness status: OK
Found 26 tests
22 Pass
1 Fail
3 Optional Feature Unsupported
Pass Resolution of width is correct when pseudo-element argument is ignored (due to no colon)
Fail Resolution of width is correct when pseudo-element argument is invalid (due to a trailing token)
Pass Resolution of width is correct for ::before and ::after pseudo-elements (single-colon)
Pass Resolution of width is correct for ::before and ::after pseudo-elements (double-colon)
Pass Pseudo-elements can use the full range of CSS syntax
Pass Resolution of width is correct for ::before and ::after pseudo-elements of display: contents elements
Pass Resolution of nonexistent pseudo-element styles
Pass Resolution of pseudo-element styles in display: none elements
Pass Item-based blockification of pseudo-elements
Pass Item-based blockification of nonexistent pseudo-elements
Pass display: contents on pseudo-elements
Pass Dynamically change to display: contents on pseudo-elements
Pass Unknown pseudo-elements
Pass CSSStyleDeclaration is immutable
Pass Unknown pseudo-element with a known identifier: backdrop
Pass Unknown pseudo-element with a known identifier: file-selector-button
Optional Feature Unsupported Unknown pseudo-element with a known identifier: grammar-error
Optional Feature Unsupported Unknown pseudo-element with a known identifier: highlight(name)
Pass Unknown pseudo-element with a known identifier: marker
Pass Unknown pseudo-element with a known identifier: placeholder
Optional Feature Unsupported Unknown pseudo-element with a known identifier: spelling-error
Pass Unknown pseudo-element with a known identifier: view-transition
Pass Unknown pseudo-element with a known identifier: view-transition-image-pair(name)
Pass Unknown pseudo-element with a known identifier: view-transition-group(name)
Pass Unknown pseudo-element with a known identifier: view-transition-old(name)
Pass Unknown pseudo-element with a known identifier: view-transition-new(name)