eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Do not normalize border radii containing their initial values

Browse Source 
Most computed border-radii contain their initial values, and since the
normalized initial border radii are always zero, there is no need to do
expensive floating point math to normalize them.
This commit is contained in:
Jonne Ransijn
2024-11-30 19:26:32 +01:00
committed by Sam Atkins
parent 9b446df7f5
commit acaf01bf7b
Notes: github-actions[bot] 2024-12-04 08:31:15 +00:00 
Author: https://github.com/yyny
Commit: https://github.com/LadybirdBrowser/ladybird/commit/acaf01bf7b6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2663
Reviewed-by: https://github.com/AtkinsSJ ✅
2 changed files with 34 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Libraries/LibWeb/Painting/PaintableBox.cpp
View File

@@ -1106,15 +1106,19 @@ void PaintableBox::resolve_paint_properties()
auto const& layout_node = this->layout_node();
// Border radii
CSSPixelRect const border_rect { 0, 0, border_box_width(), border_box_height() };
auto const& border_top_left_radius = computed_values.border_top_left_radius();
auto const& border_top_right_radius = computed_values.border_top_right_radius();
auto const& border_bottom_right_radius = computed_values.border_bottom_right_radius();
auto const& border_bottom_left_radius = computed_values.border_bottom_left_radius();
BorderRadiiData radii_data {};
if (computed_values.has_noninitial_border_radii()) {
CSSPixelRect const border_rect { 0, 0, border_box_width(), border_box_height() };
auto radii_data = normalize_border_radii_data(layout_node, border_rect, border_top_left_radius,
border_top_right_radius, border_bottom_right_radius,
border_bottom_left_radius);
auto const& border_top_left_radius = computed_values.border_top_left_radius();
auto const& border_top_right_radius = computed_values.border_top_right_radius();
auto const& border_bottom_right_radius = computed_values.border_bottom_right_radius();
auto const& border_bottom_left_radius = computed_values.border_bottom_left_radius();
radii_data = normalize_border_radii_data(layout_node, border_rect, border_top_left_radius,
border_top_right_radius, border_bottom_right_radius,
border_bottom_left_radius);
}
set_border_radii_data(radii_data);
// Box shadows