From ad92622cf496a7ed10aa55c236486ae079f9b6e7 Mon Sep 17 00:00:00 2001 From: Zaggy1024 Date: Tue, 17 Feb 2026 18:06:40 -0600 Subject: [PATCH] LibWeb: Make HTMLMediaElement's FetchController reference weak This allows the FetchController to be reclaimed when the fetch completes. --- Libraries/LibWeb/HTML/HTMLMediaElement.cpp | 1 - Libraries/LibWeb/HTML/HTMLMediaElement.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Libraries/LibWeb/HTML/HTMLMediaElement.cpp b/Libraries/LibWeb/HTML/HTMLMediaElement.cpp index 2682cdfeae9..69f91bfdb94 100644 --- a/Libraries/LibWeb/HTML/HTMLMediaElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLMediaElement.cpp @@ -105,7 +105,6 @@ void HTMLMediaElement::visit_edges(Cell::Visitor& visitor) visitor.visit(m_text_tracks); visitor.visit(m_document_observer); visitor.visit(m_source_element_selector); - visitor.visit(m_fetch_controller); visitor.visit(m_pending_play_promises); visitor.visit(m_selected_video_track); } diff --git a/Libraries/LibWeb/HTML/HTMLMediaElement.h b/Libraries/LibWeb/HTML/HTMLMediaElement.h index 4b27a93d71a..ec3980dc31f 100644 --- a/Libraries/LibWeb/HTML/HTMLMediaElement.h +++ b/Libraries/LibWeb/HTML/HTMLMediaElement.h @@ -351,7 +351,7 @@ private: GC::Ptr m_source_element_selector; - GC::Ptr m_fetch_controller; + GC::Weak m_fetch_controller; u32 m_current_fetch_generation { 0 }; RefPtr m_playback_manager;