eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Remove the null state of DeprecatedString

Browse Source 
This commit removes DeprecatedString's "null" state, and replaces all
its users with one of the following:
- A normal, empty DeprecatedString
- Optional<DeprecatedString>

Note that null states of DeprecatedFlyString/StringView/etc are *not*
affected by this commit. However, DeprecatedString::empty() is now
considered equal to a null StringView.
This commit is contained in:
Ali Mohammad Pur
2023-10-10 15:00:58 +03:30
committed by Ali Mohammad Pur
parent daf6d8173c
commit aeee98b3a1
Notes: sideshowbarker 2024-07-16 20:21:48 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/aeee98b3a1
Pull-request: https://github.com/SerenityOS/serenity/pull/21397
Reviewed-by: https://github.com/shannonbooth
Reviewed-by: https://github.com/trflynn89
189 changed files with 597 additions and 652 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibSQL/AST/AST.h
View File

@@ -186,8 +186,8 @@ public:
ResultType type() const { return m_type; }
bool select_from_table() const { return !m_table_name.is_null(); }
DeprecatedString const& table_name() const { return m_table_name; }
bool select_from_table() const { return m_table_name.has_value(); }
Optional<DeprecatedString> const& table_name() const { return m_table_name; }
bool select_from_expression() const { return !m_expression.is_null(); }
RefPtr<Expression> const& expression() const { return m_expression; }
@@ -196,7 +196,7 @@ public:
private:
ResultType m_type { ResultType::All };
DeprecatedString m_table_name {};
Optional<DeprecatedString> m_table_name {};
RefPtr<Expression> m_expression {};
DeprecatedString m_column_alias {};