eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Migrate some call sites to non-deprecated resolve_* methods

Browse Source 
This ensures that we clamp values for properties like padding-* to valid
ranges (non-negative in this case) if they are specified with `calc()`.

The length-related changes in this commit combined with the ones from
the previous commit fix the primary layout issue on https://lwn.net
(yes, not the first place I would have expected problems either).
This commit is contained in:
InvalidUsernameException
2025-09-05 16:22:17 +02:00
committed by Sam Atkins
parent 7afcf305b2
commit b057bad102
Notes: github-actions[bot] 2025-09-07 14:56:24 +00:00 
Author: https://github.com/InvalidUsernameException
Commit: https://github.com/LadybirdBrowser/ladybird/commit/b057bad1023
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6083
Reviewed-by: https://github.com/AtkinsSJ ✅
7 changed files with 55 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Tests/LibWeb/Text/expected/wpt-import/css/css-values/round-mod-rem-computed.txt
View File

@@ -2,8 +2,8 @@ Harness status: OK
Found 229 tests
215 Pass
14 Fail
217 Pass
12 Fail
Pass round(10,10) should be used-value-equivalent to 10
Pass mod(1,1) should be used-value-equivalent to 0
Pass rem(1,1) should be used-value-equivalent to 0
@@ -121,8 +121,8 @@ Pass rem(10deg,6deg) should be used-value-equivalent to 4deg
Pass rem(10grad,6grad) should be used-value-equivalent to 4grad
Pass rem(10rad,6rad) should be used-value-equivalent to 4rad
Pass rem(10turn,6turn) should be used-value-equivalent to 4turn
Fail round(10%,1px) should be used-value-equivalent to 8px
Fail round(10%,5px) should be used-value-equivalent to 10px
Pass round(10%,1px) should be used-value-equivalent to 8px
Pass round(10%,5px) should be used-value-equivalent to 10px
Pass round(2rem,5px) should be used-value-equivalent to 30px
Pass round(100px,1rem) should be used-value-equivalent to 96px
Pass round(10s,6000ms) should be used-value-equivalent to 12s