eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Libraries: Fix visibility of Object-derivative constructors

Browse Source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake
2021-10-31 23:38:04 +01:00
committed by Andreas Kling
parent 3796d417e0
commit b3e9a4e603
Notes: sideshowbarker 2024-07-18 01:33:03 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/b3e9a4e603c
Pull-request: https://github.com/SerenityOS/serenity/pull/10745
Reviewed-by: https://github.com/PeterBindels-TomTom
Reviewed-by: https://github.com/sin-ack ✅
19 changed files with 62 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h
View File

@@ -22,7 +22,6 @@ class TCPWebSocketConnectionImpl final : public AbstractWebSocketImpl {
public:
virtual ~TCPWebSocketConnectionImpl() override;
explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr);
virtual void connect(ConnectionInfo const& connection) override;
@@ -39,6 +38,8 @@ public:
virtual void discard_connection() override;
private:
explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr);
RefPtr<Core::Notifier> m_notifier;
RefPtr<Core::TCPSocket> m_socket;
};