eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibCore+LibWebView: Restore was_exit_requested to EventLoop

Browse Source 
This method was removed in e015a43b51

However, it was not exactly *unused* as the commit message would say.
This method was the only thing that allowed spin_until to exit when
the event loop was cancelled. This happens normally when IPC connections
are closed, but also when the process is killed.

The logic to properly handle process exit from event loop spins needs to
actually notify the caller that their goal condition was not met though.
That will be handled in a later commit.
This commit is contained in:
Andrew Kaster
2025-04-29 15:41:18 -06:00
committed by Tim Flynn
parent 0cd5e99066
commit b50d03f42e
Notes: github-actions[bot] 2025-04-30 15:13:48 +00:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/b50d03f42ec
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4527
Reviewed-by: https://github.com/trflynn89 ✅
9 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibCore/EventLoopImplementationWindows.h
View File

@@ -39,8 +39,8 @@ public:
virtual int exec() override;
virtual size_t pump(PumpMode) override;
virtual void quit(int) override;
virtual void wake() override;
virtual bool was_exit_requested() const override { return m_exit_requested; }
virtual void post_event(EventReceiver& receiver, NonnullOwnPtr<Event>&&) override;