eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use value-comparing RefPtr in CursorStyleValue

Browse Source 
The x and y members were RefPtr which compares by pointer identity.
This caused false positives in style invalidation when the same values
were recomputed as different objects.
This commit is contained in:
Aliaksandr Kalenik
2026-01-06 13:23:29 +01:00
committed by Sam Atkins
parent 9cd583ff6e
commit b6da3aaa3f
Notes: github-actions[bot] 2026-01-06 13:24:00 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/b6da3aaa3f7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7343
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/gmta ✅
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/CSS/StyleValues/CursorStyleValue.h
View File

@@ -45,8 +45,8 @@ private:
struct Properties {
ValueComparingNonnullRefPtr<AbstractImageStyleValue const> image;
RefPtr<StyleValue const> x;
RefPtr<StyleValue const> y;
ValueComparingRefPtr<StyleValue const> x;
ValueComparingRefPtr<StyleValue const> y;
bool operator==(Properties const&) const = default;
} m_properties;