eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 03:57:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove Bindings/Forward.h from LibWeb/Forward.h

Browse Source 
This was resulting in a whole lot of rebuilding whenever a new IDL
interface was added.

Instead, just directly include the prototype in every C++ file which
needs it. While we only really need a forward declaration in each cpp
file; including the full prototype header (which itself only includes
LibJS/Object.h, which is already transitively brought in by
PlatformObject) - it seems like a small price to pay compared to what
feels like a full rebuild of LibWeb whenever a new IDL file is added.

Given all of these includes are only needed for the ::initialize
method, there is probably a smart way of avoiding this problem
altogether. I've considered both using some macro trickery or generating
these functions somehow instead.
This commit is contained in:
Shannon Booth
2024-04-27 12:09:58 +12:00
committed by Tim Flynn
parent b1205f0aa1
commit bad44f8fc9
Notes: sideshowbarker 2024-07-17 18:46:57 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/bad44f8fc9
Pull-request: https://github.com/SerenityOS/serenity/pull/24128
Reviewed-by: https://github.com/trflynn89 ✅
228 changed files with 228 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/DOMURL/DOMURL.cpp
View File

@@ -9,6 +9,7 @@
#include <AK/IPv4Address.h>
#include <AK/IPv6Address.h>
#include <LibURL/Parser.h>
#include <LibWeb/Bindings/DOMURLPrototype.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/DOMURL/DOMURL.h>
#include <LibWeb/FileAPI/Blob.h>