eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-09 16:42:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Implement basic chmod() syscall and /bin/chmod helper.

Browse Source 
Only raw octal modes are supported right now.
This patch also changes mode_t from 32-bit to 16-bit to match the on-disk
type used by Ext2FS.

I also ran into EPERM being errno=0 which was confusing, so I inserted an
ESUCCESS in its place.
This commit is contained in:
Andreas Kling
2019-01-29 04:55:08 +01:00
parent ad53f6afd3
commit c30e2c8d44
Notes: sideshowbarker 2024-07-19 15:55:24 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/c30e2c8d440
22 changed files with 156 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
Kernel/VirtualFileSystem.cpp
View File

@@ -228,6 +228,37 @@ bool VFS::mkdir(const String& path, mode_t mode, InodeIdentifier base, int& erro
return false;
}
bool VFS::chmod(const String& path, mode_t mode, Inode& base, int& error)
{
error = -EWHYTHO;
// FIXME: This won't work nicely across mount boundaries.
FileSystemPath p(path);
if (!p.is_valid()) {
error = -EINVAL;
return false;
}
InodeIdentifier parent_dir;
auto inode_id = resolve_path(path, base.identifier(), error, 0, &parent_dir);
if (!inode_id.is_valid()) {
error = -ENOENT;
return false;
}
auto inode = get_inode(inode_id);
// FIXME: Permission checks.
// Only change the permission bits.
mode = (inode->mode() & ~04777) | (mode & 04777);
kprintf("VFS::chmod(): %u:%u mode %o\n", inode_id.fsid(), inode_id.index(), mode);
if (!inode->chmod(mode, error))
return false;
error = 0;
return true;
}
bool VFS::unlink(const String& path, Inode& base, int& error)
{
error = -EWHYTHO;