eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-12 18:08:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+RequestServer: Send cached bytecode with responses

Browse Source 
Attach cached JavaScript bytecode sidecars to HTTP response headers so
WebContent can materialize classic and module scripts directly from a
decoded cache blob on cache hits.

Carry the disk cache vary key with the sidecar and reuse it when storing
fresh bytecode, avoiding mismatches against the augmented network
request headers used to create the cache entry.

Keep CORS-filtered module responses intact for status, MIME, and script
creation checks. Read bytecode sidecar data only from the internal
response, and treat decode or materialization failure as a cache miss
that falls back to normal source compilation.
This commit is contained in:
Andreas Kling
2026-05-03 20:04:35 +02:00
committed by Andreas Kling
parent 557191decb
commit c32b5a3f73
Notes: github-actions[bot] 2026-05-06 06:21:12 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c32b5a3f731
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9259
30 changed files with 280 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Libraries/LibWeb/HTML/Scripting/ClassicScript.cpp
View File

@@ -138,6 +138,39 @@ GC::Ref<ClassicScript> ClassicScript::create_from_pre_compiled(ByteString filena
return script;
}
GC::Ref<ClassicScript> ClassicScript::create_from_bytecode_cache(ByteString filename, NonnullRefPtr<JS::SourceCode const> source_code, EnvironmentSettingsObject& settings, URL::URL base_url, JS::FFI::DecodedBytecodeCacheBlob* bytecode_cache, MutedErrors muted_errors)
{
auto& realm = settings.realm();
auto& vm = realm.vm();
if (muted_errors == MutedErrors::Yes)
base_url = URL::about_blank();
auto script = vm.heap().allocate<ClassicScript>(move(base_url), move(filename), settings);
script->m_muted_errors = muted_errors;
script->set_parse_error(JS::js_null());
script->set_error_to_rethrow(JS::js_null());
auto parse_timer = Core::ElapsedTimer::start_new();
auto result = JS::Script::create_from_bytecode_cache(bytecode_cache, move(source_code), realm, script);
dbgln_if(HTML_SCRIPT_DEBUG, "ClassicScript: Materialized cached bytecode {} in {}ms", script->filename(), parse_timer.elapsed_milliseconds());
if (result.is_error()) {
auto& parse_error = result.error().first();
dbgln_if(HTML_SCRIPT_DEBUG, "ClassicScript: Failed to materialize bytecode cache: {}", parse_error.to_string());
script->set_parse_error(JS::SyntaxError::create(realm, parse_error.to_string()));
script->set_error_to_rethrow(script->parse_error());
return script;
}
script->m_script_record = *result.release_value();
return script;
}
// https://html.spec.whatwg.org/multipage/webappapis.html#run-a-classic-script
JS::Completion ClassicScript::run(RethrowErrors rethrow_errors, GC::Ptr<JS::Environment> lexical_environment_override)
{