eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Convert Object bitfields to a flags byte

Browse Source 
Replace individual bool bitfields in Object (m_is_extensible,
m_has_parameter_map, m_has_magical_length_property, etc.) with a
single u8 m_flags field and Flag:: constants.

This consolidates 8 scattered bitfields into one byte with explicit
bit positions, making them easy to access from generated assembly
code at a known offset. It also converts the virtual is_function()
and is_ecmascript_function_object() methods to flag-based checks,
avoiding virtual dispatch for these hot queries.

ProxyObject now explicitly clears the IsFunction flag in its
constructor when wrapping a non-callable target, instead of relying
on a virtual is_function() override.
This commit is contained in:
Andreas Kling
2026-03-06 22:05:13 +01:00
committed by Andreas Kling
parent 643f2884cc
commit c5427e5f4e
Notes: github-actions[bot] 2026-03-07 12:12:35 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c5427e5f4e1
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8299
10 changed files with 68 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/LibJS/Runtime/ECMAScriptFunctionObject.h
View File

@@ -139,7 +139,6 @@ private:
[[nodiscard]] bool function_environment_needed() const { return shared_data().m_function_environment_needed; }
SharedFunctionInstanceData const& shared_data() const { return m_shared_data; }
virtual bool is_ecmascript_function_object() const override { return true; }
virtual void visit_edges(Visitor&) override;
void prepare_for_ordinary_call(VM&, ExecutionContext& callee_context, Object* new_target);