eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 20:42:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't have Handle<Realm> in WindowEnvironmentSettingsObject

Browse Source 
This was preventing window realms from ever being garbage collected.
This commit is contained in:
Andreas Kling
2022-09-01 12:14:28 +02:00
parent 5f4d4ffe39
commit c569c88e63
Notes: sideshowbarker 2024-07-17 07:27:55 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/c569c88e63
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h
View File

@@ -26,7 +26,7 @@ public:
private:
WindowEnvironmentSettingsObject(Window&, NonnullOwnPtr<JS::ExecutionContext>);
JS::Handle<Window> m_window;
WeakPtr<Window> m_window;
};
}