eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move and rename CSSStyleValue to StyleValues/StyleValue.{h,cpp}

Browse Source 
This reverts 0e3487b9ab.

Back when I made that change, I thought we could make our StyleValue
classes match the typed-om definitions directly. However, they have
different requirements. Typed-om types need to be mutable and GCed,
whereas StyleValues are immutable and ideally wouldn't require a JS VM.

While I was already making such a cataclysmic change, I've moved it into
the StyleValues directory, because it *not* being there has bothered me
for a long time. 😅
This commit is contained in:
Sam Atkins
2025-08-08 10:11:51 +01:00
committed by Tim Ledbetter
parent 0d8ad0a9fe
commit c57975c9fd
Notes: github-actions[bot] 2025-08-08 14:20:54 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c57975c9fdb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5775
Reviewed-by: https://github.com/tcl3 ✅
167 changed files with 989 additions and 990 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleValues/CSSNumericValue.h
View File

@@ -6,18 +6,18 @@
#pragma once
#include <LibWeb/CSS/CSSStyleValue.h>
#include <LibWeb/CSS/StyleValues/StyleValue.h>
namespace Web::CSS {
// https://drafts.css-houdini.org/css-typed-om-1/#cssnumericvalue
class CSSNumericValue : public CSSStyleValue {
class CSSNumericValue : public StyleValue {
public:
virtual ~CSSNumericValue() override = default;
protected:
explicit CSSNumericValue(Type type)
: CSSStyleValue(type)
: StyleValue(type)
{
}
};