eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 04:52:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Do not return a GC::Root from HTMLTrackElement's track getter

Browse Source 
There's no need to create a root each time the getter is called. We
should also allocate it in the `initialize` overload rather than the
constructor.
This commit is contained in:
Timothy Flynn
2025-06-12 07:56:37 -04:00
committed by Tim Flynn
parent 642dd751cf
commit c6a94fe513
Notes: github-actions[bot] 2025-06-12 16:27:10 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c6a94fe5131
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5068
Reviewed-by: https://github.com/tcl3
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLTrackElement.h
View File

@@ -21,7 +21,7 @@ public:
WebIDL::UnsignedShort ready_state();
GC::Root<TextTrack> track() { return m_track; }
GC::Ref<TextTrack> track() { return *m_track; }
private:
HTMLTrackElement(DOM::Document&, DOM::QualifiedName);