eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-11 09:27:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move element state style invalidation into a helper

Browse Source 
Several HTML element state changes directly selected style invalidation
reasons from their element implementations. Move those mappings into a
new CSS::Invalidation::ElementStateInvalidator helper.

This keeps details, dialog, option, and select code focused on their own
state changes while CSS invalidation owns the style work those changes
require. The existing invalidation breadth is preserved.
This commit is contained in:
Andreas Kling
2026-04-29 12:24:07 +02:00
committed by Alexander Kalenik
parent 79c32f88d2
commit c93dad7600
Notes: github-actions[bot] 2026-04-29 13:49:00 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c93dad76009
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9160
7 changed files with 67 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/HTML/HTMLDialogElement.cpp
View File

@@ -9,6 +9,7 @@
#include <LibWeb/Bindings/HTMLDialogElement.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Bindings/PrincipalHostDefined.h>
#include <LibWeb/CSS/Invalidation/ElementStateInvalidator.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/DOM/IDLEventListener.h>
@@ -516,7 +517,7 @@ void HTMLDialogElement::set_is_modal(bool is_modal)
if (m_is_modal == is_modal)
return;
m_is_modal = is_modal;
invalidate_style(DOM::StyleInvalidationReason::HTMLDialogElementSetIsModal);
CSS::Invalidation::invalidate_style_after_modal_state_change(*this);
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element:is-valid-command-steps
@@ -675,9 +676,7 @@ void HTMLDialogElement::attribute_changed(FlyString const& local_name, Optional<
if (local_name != "open"_fly_string)
return;
// The :open pseudo-class can affect sibling selectors (e.g., dialog:open + sibling),
// so we need full subtree + sibling invalidation, not just targeted invalidation.
invalidate_style(DOM::StyleInvalidationReason::HTMLDetailsOrDialogOpenAttributeChange);
CSS::Invalidation::invalidate_style_after_open_state_change(*this);
// 3. If value is null and oldValue is not null, then run the dialog cleanup steps given element.
if (!value.has_value() && old_value.has_value())