eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make PolicyContainer GC allocated

Browse Source 
This is required to store Content Security Policies, as their
Directives are implemented as subclasses with overridden virtual
functions. Thus, they cannot be stored as generic Directive classes, as
it'll lose the ability to call overridden functions when they are
copied.
This commit is contained in:
Luke Wilde
2024-11-25 14:30:12 +00:00
committed by Sam Atkins
parent 2e27ffab6c
commit cae0ab2139
Notes: github-actions[bot] 2025-02-21 12:55:13 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cae0ab2139a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3627
Reviewed-by: https://github.com/AtkinsSJ ✅
43 changed files with 381 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/SessionHistoryEntry.h
View File

@@ -69,8 +69,8 @@ public:
[[nodiscard]] ScrollRestorationMode scroll_restoration_mode() const { return m_scroll_restoration_mode; }
void set_scroll_restoration_mode(ScrollRestorationMode scroll_restoration_mode) { m_scroll_restoration_mode = scroll_restoration_mode; }
[[nodiscard]] Optional<PolicyContainer> const& policy_container() const { return m_policy_container; }
void set_policy_container(Optional<PolicyContainer> policy_container) { m_policy_container = move(policy_container); }
[[nodiscard]] GC::Ptr<PolicyContainer> policy_container() const { return m_policy_container; }
void set_policy_container(GC::Ptr<PolicyContainer> policy_container) { m_policy_container = policy_container; }
[[nodiscard]] Optional<ByteString> const& browsing_context_name() const { return m_browsing_context_name; }
void set_browsing_context_name(Optional<ByteString> browsing_context_name) { m_browsing_context_name = move(browsing_context_name); }
@@ -111,7 +111,7 @@ private:
ScrollRestorationMode m_scroll_restoration_mode { ScrollRestorationMode::Auto };
// policy container, a policy container or null
Optional<PolicyContainer> m_policy_container;
GC::Ptr<PolicyContainer> m_policy_container;
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-scroll-position
// FIXME: scroll position data, which is scroll position data for the document's restorable scrollable regions