eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't loop the media element when paused

Browse Source 
We should be able to seek to the end of the media without looping if
we're paused.

See: https://github.com/whatwg/html/issues/11774
This commit is contained in:
Zaggy1024
2025-10-10 15:36:13 -05:00
committed by Jelle Raaijmakers
parent 4471e8c0ec
commit cb1719aa81
Notes: github-actions[bot] 2025-10-28 00:30:57 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cb1719aa81f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6410
Reviewed-by: https://github.com/R-Goc
Reviewed-by: https://github.com/gmta ✅
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -1626,6 +1626,13 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::play_element()
// notify about playing for the element.
else {
notify_about_playing();
// AD-HOC: If the official playback position is at the end of the media data here, that means that we haven't
// run the reached the end of media playback steps. This can happen if we seeked to the end while paused
// and looping.
// See https://github.com/whatwg/html/issues/11774
if (m_official_playback_position == m_duration)
reached_end_of_media_playback();
}
}
@@ -2033,7 +2040,10 @@ void HTMLMediaElement::reached_end_of_media_playback()
m_loop_was_specified_when_reaching_end_of_media_resource = has_attribute(HTML::AttributeNames::loop);
if (m_loop_was_specified_when_reaching_end_of_media_resource) {
// then seek to the earliest possible position of the media resource and return.
seek_element(0);
// AD-HOC: We don't want to loop back to the start if we're paused.
// See https://github.com/whatwg/html/issues/11774
if (!paused())
seek_element(0);
// FIXME: Tell PlaybackManager that we're looping to allow data providers to decode frames ahead when looping
// and remove any delay in displaying the first frame again.
return;