eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Replace is<T>() with as_if<T>() where possible

Browse Source
This commit is contained in:
Tim Ledbetter
2025-08-25 07:22:57 +01:00
committed by Jelle Raaijmakers
parent 3d97251da3
commit cb1a1a5cb5
Notes: github-actions[bot] 2025-08-25 16:46:19 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cb1a1a5cb58
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5985
Reviewed-by: https://github.com/gmta ✅
26 changed files with 92 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Libraries/LibWeb/HTML/HTMLTableElement.cpp
View File

@@ -213,8 +213,7 @@ GC::Ptr<HTMLTableSectionElement> HTMLTableElement::t_head()
// The tHead IDL attribute must return, on getting, the first thead element child of the table element,
// if any, or null otherwise.
for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &as<HTMLTableSectionElement>(*child);
if (auto* table_section_element = as_if<HTMLTableSectionElement>(*child)) {
if (table_section_element->local_name() == TagNames::thead)
return table_section_element;
}
@@ -248,8 +247,7 @@ WebIDL::ExceptionOr<void> HTMLTableElement::set_t_head(HTMLTableSectionElement*
continue;
if (is<HTMLTableCaptionElement>(*child))
continue;
if (is<HTMLTableColElement>(*child)) {
auto table_col_element = &as<HTMLTableColElement>(*child);
if (auto* table_col_element = as_if<HTMLTableColElement>(*child)) {
if (table_col_element->local_name() == TagNames::colgroup)
continue;
}
@@ -280,8 +278,7 @@ GC::Ref<HTMLTableSectionElement> HTMLTableElement::create_t_head()
continue;
if (is<HTMLTableCaptionElement>(*child))
continue;
if (is<HTMLTableColElement>(*child)) {
auto table_col_element = &as<HTMLTableColElement>(*child);
if (auto* table_col_element = as_if<HTMLTableColElement>(*child)) {
if (table_col_element->local_name() == TagNames::colgroup)
continue;
}
@@ -311,8 +308,7 @@ GC::Ptr<HTMLTableSectionElement> HTMLTableElement::t_foot()
// The tFoot IDL attribute must return, on getting, the first tfoot element child of the table element,
// if any, or null otherwise.
for (auto* child = first_child(); child; child = child->next_sibling()) {
if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &as<HTMLTableSectionElement>(*child);
if (auto* table_section_element = as_if<HTMLTableSectionElement>(*child)) {
if (table_section_element->local_name() == TagNames::tfoot)
return table_section_element;
}
@@ -384,8 +380,7 @@ GC::Ref<HTMLTableSectionElement> HTMLTableElement::create_t_body()
for (auto* child = last_child(); child; child = child->previous_sibling()) {
if (!is<HTMLElement>(*child))
continue;
if (is<HTMLTableSectionElement>(*child)) {
auto table_section_element = &as<HTMLTableSectionElement>(*child);
if (auto* table_section_element = as_if<HTMLTableSectionElement>(*child)) {
if (table_section_element->local_name() == TagNames::tbody) {
// We have found an element which is a <tbody> we'll insert after this
child_to_insert_before = child->next_sibling();