eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove Token::number()

Browse Source 
In a future commit we will be applying clamping to numeric (i.e.
number, percentage, dimension) values which will be done in the
appropriate `Token` getters so accessing the underlying number value
would be a potential footgun
This commit is contained in:
Callum Law
2026-04-15 22:21:32 +12:00
committed by Sam Atkins
parent da5e002db1
commit cbf6e4454d
Notes: github-actions[bot] 2026-04-22 13:26:29 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/cbf6e4454d5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8959
Reviewed-by: https://github.com/AtkinsSJ ✅
7 changed files with 31 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/CSS/Parser/ArbitrarySubstitutionFunctions.cpp
View File

@@ -277,9 +277,8 @@ static Vector<ComponentValue> replace_an_env_function(DOM::AbstractElement& elem
auto& maybe_integer = first_argument_tokens.consume_a_token();
if (!maybe_integer.is(Token::Type::Number))
return { ComponentValue { GuaranteedInvalidValue {} } };
auto& number = maybe_integer.token().number();
if (number.is_integer() && number.integer_value() >= 0)
indices.append(number.integer_value());
if (maybe_integer.token().is_integer() && maybe_integer.token().to_integer() >= 0)
indices.append(maybe_integer.token().to_integer());
else
return { ComponentValue { GuaranteedInvalidValue {} } };
first_argument_tokens.discard_whitespace();